Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add events util tests #1218

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

lukasaric
Copy link
Contributor

@lukasaric lukasaric commented Sep 3, 2024

Motivation and Resolution

Write events util tests to improve tests coverage. That includes tests for these utiils:

  • - isAbiEvent
  • - getAbiEvents
  • - parseEvents
  • - parseUDCEvent

It resolves: #1217

RPC version (if applicable)

n.a

Usage related changes

n.a

Development related changes

isObject will not be covered here since it is moved to a different util in #1212

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@lukasaric lukasaric marked this pull request as draft September 3, 2024 19:40
@lukasaric lukasaric marked this pull request as ready for review September 5, 2024 06:45
src/utils/events/index.ts Show resolved Hide resolved
@ivpavici ivpavici merged commit 41ed6e6 into starknet-io:develop Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utils events tests
3 participants