Skip to content

Commit

Permalink
fix: implement requests of Ivan
Browse files Browse the repository at this point in the history
  • Loading branch information
PhilippeR26 committed Aug 20, 2024
1 parent 548bae4 commit 0d0d2c7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions __tests__/rpcProvider.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -494,9 +494,7 @@ describeIfNotDevnet('waitForBlock', () => {
});
});

describeIfDevnet('EIP712 verification', () => {
// currently only in Devnet-rs, because can fail in Sepolia.
// to test in all cases once PR#989 implemented.
describe('EIP712 verification', () => {
const rpcProvider = getTestProvider(false);
const account = getTestAccount(rpcProvider);

Expand Down
4 changes: 2 additions & 2 deletions www/docs/guides/signature.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const msgHash1 = hash.computeHashOnElements(message);
const isValid1 = typedData.verifyMessage(msgHash1, signature, fullPublicKey);
console.log('Result (boolean) =', isValid1);

// with a low level function (take care to Types limitations) :
// with a low level function (take care of Types limitations) :
const isValid2 = ec.starkCurve.verify(signature1, msgHash, fullPublicKey);
```

Expand Down Expand Up @@ -167,7 +167,7 @@ A verification is also possible if you have the message hash, the signature and
```typescript
const isValid2 = typedData.verifyMessage(msgHash, signature, fullPublicKey);

// with a low level function (take care to Types limitations) :
// with a low level function (take care of Types limitations) :
const isValid3 = ec.starkCurve.verify(signature, msgHash, fullPublicKey);
```

Expand Down

0 comments on commit 0d0d2c7

Please sign in to comment.