Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the newest StarknetTokenBridge besides LegacyBridge #337

Open
9oelM opened this issue Mar 27, 2024 · 0 comments
Open

Support the newest StarknetTokenBridge besides LegacyBridge #337

9oelM opened this issue Mar 27, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@9oelM
Copy link

9oelM commented Mar 27, 2024

Is your feature request related to a problem? Please describe.
Hi, I'm Joel from @zkLend. As you might already know, the current version of Starkgate frontend and backend does not support StarknetTokenBridge (aka MultiBridge). It seems that ZEND is the only token that possibly uses this bridge extensively for now. But as Starknet grows, there will be more tokens that will need to use StarknetTokenBridge in the future. I mean, it is designed to replace the LegacyBridge, so we need to support the newest StarknetTokenBridge on Starkgate right?

Describe the solution you'd like
First, a few changes need to be made to the frontend because it only supports interaction with LegacyBridge. The arguments and the function names would be a bit different for StarknetTokenBridge because it is meant to support various tokens unlike the LegacyBridge that only supports one token per bridge deployed. For example, a call towithdraw(uint256 amount, address recipient) should change to withdraw(address token, uint256 amount, address recipient), and initiate_withdraw should change to initiate_token_withdraw, and so on.

Then, the existing indexer that is hosted at https://starkgate.starknet.io/transfer-log/api/* would also need to support indexing events from StarknetTokenBridge and the corresponding L2 bridge, because the indexer seems to only pick up events from the existing LegacyBridges.

To facilitate the usage of ZEND token across L1 and L2, a fork has been made at https://github.com/zkLend/zend-bridge with a permission from Starknet and the relevant changes were created here to enable the transfer bilaterally. But it is only meant to be a temporary measure and we would ideally want MultiBridge to be supported at https://starkgate.starknet.io/.

On a related note, @0xSpaceShard team might also want to work on the automatic withdrawal of tokens that use StarknetTokenBridge, as their one-click withdrawal only seems to work with the tokens using LegacyBridge based on some tests I've done.

@9oelM 9oelM added the enhancement New feature or request label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants