Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choosing a new folder for VDFS doesn't start at the existing one on windows. #204

Open
mark-usher opened this issue Jun 13, 2023 · 4 comments

Comments

@mark-usher
Copy link

On windows...
Line 1016 in gui-allegro.c
if ((chooser = al_create_native_file_dialog(vdfs_get_root(), "Choose a folder to be the VDFS root - ", "*", ALLEGRO_FILECHOOSER_FOLDER))) {
even though the vdfs root is correct and being returned, it isn't being set as the initial path in the allegro created dialog in windows.
Allegro 5 bug?

@SteveFosdick
Copy link
Collaborator

This seems to be a feature of Allegro 5. Looking at the code in https://github.com/liballeg/allegro5/blob/master/addons/native_dialog/win_dialog.c when the flag ALLEGRO_FILECHOOSER_FOLDER is passed in, almost all the work is done by a separate function that ignores the initial path specified and ends up calling a completely different Windows function than the one that browses for files.

The next step is probably to check if Allegro have this logged as a bug.

@SteveFosdick
Copy link
Collaborator

I have raised one: liballeg/allegro5#1449

@mark-usher
Copy link
Author

Thanks Steve :) I thought it was looking to be on the Allegro side as the variables were holding the expected values before it was handed off.

@joecarl
Copy link

joecarl commented Sep 28, 2023

The next Allegro release will fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants