Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] revert move AccountDataCache #4156

Open
nkysg opened this issue Jul 9, 2024 · 0 comments
Open

[Feature Request] revert move AccountDataCache #4156

nkysg opened this issue Jul 9, 2024 · 0 comments
Labels
enhancement Enhancement

Comments

@nkysg
Copy link
Collaborator

nkysg commented Jul 9, 2024

Feature Request

Describe the Feature Request

Because of this feature starcoinorg/diem#161
we changed

pub struct AccountDataCache {
    data_map: BTreeMap<StructTag, (MoveTypeLayout, GlobalValue)>,
    module_map: BTreeMap<Identifier, Vec<u8>>,
}

we need to revert to this one

pub struct AccountDataCache {
    data_map: BTreeMap<Type, (MoveTypeLayout, GlobalValue)>,
    module_map: BTreeMap<Identifier, Vec<u8>>,
}

Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)

@nkysg nkysg added the enhancement Enhancement label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant