Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review + test that all maneuver images work #302

Open
ianthetechie opened this issue Oct 19, 2024 · 1 comment
Open

Review + test that all maneuver images work #302

ianthetechie opened this issue Oct 19, 2024 · 1 comment
Labels
android chore It has to be done sometime... iOS UI/UX Related to the UI/UX (on any platform) web

Comments

@ianthetechie
Copy link
Contributor

We should have some sort of (ideally self-generating) tests in place that ensure all (valid?) maneuver combinations generate valid maneuver images using the platform views. We have had a few random issues with this on iOS and Android in the past, and I suspect we haven't found them all.

@ianthetechie ianthetechie added android iOS UI/UX Related to the UI/UX (on any platform) chore It has to be done sometime... web labels Oct 19, 2024
@Archdoog
Copy link
Collaborator

I also found that our android maneuver images are not tinted properly in dark mode. We probably want them to be tinted to MaterialTheme.colorScheme.onWhatever (e.g. onPrimary). Currently you can't see them in dark mode because they're still black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android chore It has to be done sometime... iOS UI/UX Related to the UI/UX (on any platform) web
Projects
Status: No status
Development

No branches or pull requests

2 participants