Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add ability to hide/show the Tour #144

Open
ravanscafi opened this issue Apr 2, 2024 · 1 comment
Open

Suggestion: Add ability to hide/show the Tour #144

ravanscafi opened this issue Apr 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ravanscafi
Copy link

Hello 👋

I would love to have the ability to hide the tour temporarily and then show it again.
I want the user to be able to perform some actions in between the steps.

I can mimic this behavior by saving the last non-undefined current, calling stop(), and then calling goTo(lastCurrent). However, it's far from ideal, as it has the setSpot(ZERO_SPOT) on the stop() method it performs some animations (at least in slide).

The context could provide a simple hide() and show() that is managed by the library itself, making it easier to use and with better (or no) transitions. Also, calling next()/previous() could still work anyway :)

@JoseLion JoseLion added good first issue Good for newcomers enhancement New feature or request labels Jul 29, 2024
@hdbv95
Copy link
Contributor

hdbv95 commented Jul 29, 2024

Hey @ravanscafi, thanks for showing interest in the library, as for your suggestion, I'll give it a try but will be using pause() instead of hide() for it to fit better with the existing methods.

@hdbv95 hdbv95 self-assigned this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants