Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action? #225

Open
mmkal opened this issue Sep 4, 2024 · 2 comments
Open

GitHub Action? #225

mmkal opened this issue Sep 4, 2024 · 2 comments

Comments

@mmkal
Copy link
Contributor

mmkal commented Sep 4, 2024

Given this is supposed to be used from GitHub action workflows (exclusively?), it doesn't seem necessary to tell all users to do npm install pkg-pr-new.

What if we could just add uses: stackblitz-labs/pkg.pr.new@v0 to a GitHub Actions workflow. e.g.

name: ci
on: [push, pull_request]
jobs:
  run:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - run: npm install
      - run: npm run build
      - uses: stackblitz-labs/pkg.pr.new@v0

Under the hood it could probably just do npx pkg-pr-new@latest anyway, but it'd mean that it'd be just one step to add to a repo - also you'd see that it's owned by stackblitz and therefore probably pretty safe to use.

@Aslemammad
Copy link
Member

I'm thinking about this, it's solid, how can we handle options at that point? like compact, templates and projects?

@mmkal
Copy link
Contributor Author

mmkal commented Sep 10, 2024

how can we handle options at that point? like compact, templates and projects?

      - uses: stackblitz-labs/pkg.pr.new@v0
        with:
          projects: 'packages/*'
          template: foo
          compact: true
          comment: create

Or maybe keep it simpler:

      - uses: stackblitz-labs/pkg.pr.new@v0
        with:
          args: 'packages/* --template foo --compact --comment=create'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants