Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to use homogenize parsing of models between SDF/URDF/MJCF #2433

Open
MegMll opened this issue Sep 24, 2024 · 1 comment
Open

Find a way to use homogenize parsing of models between SDF/URDF/MJCF #2433

MegMll opened this issue Sep 24, 2024 · 1 comment

Comments

@MegMll
Copy link
Collaborator

MegMll commented Sep 24, 2024

Currently, Pinocchio supports multiple model formats such as URDF, SDF, and MJCF.

However, there is a lack of homogeneity in how these formats are parsed and handled.

Maybe we can try to think of a way to have some homogeneity in the way all these formats and future formats are parsed as pinocchio models, to avoid having a lot of overloaded buildModel functions.

@jorisv
Copy link
Contributor

jorisv commented Sep 24, 2024

We must provide an homogeneous API to read each format.

  • Some don't have argument in the same orders
  • There is many arguments
  • There is many version of the same function to avoid breaking the API.
    It's even worst in Python.
    We can maybe use the builder pattern to provide an API that can evolve without breaking the API and that manage lot of optional arguments.

We must fix mjcf::buildModel and mjcf::buildModelFromXML that all read from a filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants