Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Pinocchio deprecate getKKTContactDynamicMatrixInverse? #2401

Open
cmastalli opened this issue Sep 2, 2024 · 0 comments
Open

Should Pinocchio deprecate getKKTContactDynamicMatrixInverse? #2401

cmastalli opened this issue Sep 2, 2024 · 0 comments
Assignees

Comments

@cmastalli
Copy link
Member

Hi guys!

The getKKTContactDynamicMatrixInverse is a deprecated version in the latest version. Is there a reason to deprecate this function?

For instance, it is a useful function we use in Crocoddyl when computing the impulse-dynamics derivatives (see https://github.com/loco-3d/crocoddyl/blob/master/include/crocoddyl/multibody/actions/impulse-fwddyn.hxx#L231-L238). Moreover, replacing this function by computeKKTContactDynamicMatrixInverse would lead to inefficiencies in our code.

Without considering the details of Pinocchio's development strategy, I would suggest not deprecating it. It

Thanks in advance for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants