-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installed eigenpyConfig.cmake
finds a different python executable version
#413
Comments
I think you are right, and we should export this. You can also bypass this with |
I took a look at https://github.com/jrl-umi3218/jrl-cmakemodules/blob/master/python.cmake#L58, and sadly it seems that the arguments to |
If I'm not wrong I'm the one who wrote that. I'm 99% sure it did work when I wrote that. |
After double checking, yes, it was using |
This is still in https://github.com/jrl-umi3218/jrl-cmakemodules/blob/master/python.cmake#L214, but only for CMake < 3.12, And we also enforce CMake >= 3.10. |
Still an issue @jmirabel? |
I don't think the issue has been resolved. It would be cleaner to set the Python version in the export file but I would not mind if you prefer to close this. It is rather easy to bypass. @nim65s a low effort solution would be to compare the Python version found with the exported compile-time Python version and just fail when they happen to be different. |
I still think we should set this version in the |
If I am not wrong, the version of the Python executable is not export and only the boost component (e.g.
python38
) contains some version information.When installing it as a binary package from robotpkg, we hit a case where the python executable found by
eigenpyConfig.cmake
is Python 2.7 while we installedrobotpkg-py38-eigenpy
.Shouldn't the version of the Python executable be stored in the Eigenpy cmake config file and used to find the correct python executable?
I know I can bypass this by setting manually the PYTHON_EXECUTABLE variable.
The text was updated successfully, but these errors were encountered: