Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection search rest endpoint conflict #749

Closed
ccancellieri opened this issue Sep 11, 2024 · 2 comments
Closed

Collection search rest endpoint conflict #749

ccancellieri opened this issue Sep 11, 2024 · 2 comments

Comments

@ccancellieri
Copy link

Hi I'm opening this 'issue' to discuss about collection search.
Here is a working proposal but I've had to change the endpoint.
stac-utils/stac-fastapi-elasticsearch-opensearch#298

I'm encountering the following problems:

We still need to use the POST to create new Collection(s) but the incoming expected body is different
Incompatible with Transactional (how to have it working?)

Questions:

Why the specifications define a new endpoint to search for items: .../search while for the collections we are overloading the /collections ?
Do you have any working example about having both search and creation working at the same time?

@vincentsarago
Copy link
Member

Hi @ccancellieri

This was already discussed in #736 and #739

stac-fastapi itself allow you to create both, but you can't have both in the same application 🤷 IMO this is an issue at the specification level

In theory we could have a POST - /Collections endpoint which support both the search and the transaction but both are separate extension which are not linked which is why we (in the first iteration) could not propose a unify solution. That's said you could create such endpoint in your own application.

Worth noting that both POST - /Collections for search and for transaction should required different auth system (I don't think you'll want everyone to be able to create new collection, but you want everyone to search for them) which in a case of a unify solution will make the code base quite a mess (if we, at stac-fastapi level, try to support this)

@ccancellieri
Copy link
Author

I'm going to discuss this over the spec repo as it looks a clear overlap:
stac-api-extensions/collection-search#17

@stac-utils stac-utils locked and limited conversation to collaborators Sep 20, 2024
@vincentsarago vincentsarago converted this issue into discussion #751 Sep 20, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants