Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify identifier arrangement for entities #377

Open
odrotbohm opened this issue Dec 1, 2021 · 0 comments
Open

Simplify identifier arrangement for entities #377

odrotbohm opened this issue Dec 1, 2021 · 0 comments
Assignees
@odrotbohm
Labels
module: catalog Product Catalog module: core Core / Time / Quantity / Payment module: inventory Inventory module: orders Orders module: user accounts User Accounts type: enhancement Improvements and new features

Comments

@odrotbohm
Copy link
Member

Currently, we use a common supertype for all identifiers which is mapped as @MappedSuperclass, which is a bit weird as they should rather just be embeddables.

We could rather use jMolecules Identifier and simple value type implementations.
@odrotbohm odrotbohm added type: enhancement Improvements and new features module: orders Orders module: user accounts User Accounts module: inventory Inventory module: core Core / Time / Quantity / Payment module: catalog Product Catalog labels Dec 1, 2021
@odrotbohm odrotbohm self-assigned this Dec 1, 2021
odrotbohm added a commit that referenced this issue Dec 6, 2021
@odrotbohm
#377 - Improved identifier arrangements for entities.
f2cebf3 
We now use simple Identifier implementations for identifiers. Moved the identifiers into the corresponding entities.
odrotbohm added a commit that referenced this issue Dec 6, 2021
@odrotbohm
#377 - Provide proper fallback for potentially missing ConversionServ…
6f514ce 
…ice in JpaEntityConverter.
odrotbohm added a commit that referenced this issue Jan 17, 2022
@odrotbohm
#377 - Provide proper fallback for potentially missing ConversionServ…
d01d938 
…ice in JpaEntityConverter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
module: catalog Product Catalog module: core Core / Time / Quantity / Payment module: inventory Inventory module: orders Orders module: user accounts User Accounts type: enhancement Improvements and new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@odrotbohm