-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby >2.4.0 required #1
Comments
I've always strived to maintain compatibility with all supported versions of Ruby. Versions of Ruby before 2.4 have not been supported for a while, and 2.4 itself is currently being sunset. There are a lot of unpatched issues in earlier versions of Ruby and I strongly encourage you to upgrade. That being said it is easy enough to workaround not using #compact, and I've already released a version (2.1.4) that switches to #reject to accomplished the same thing. You can see that change here. Could you test and see if this solves your issue? |
This appears to fix the issue I was experiencing, though is far more than I expected from you, much appreciated! I was more looking for updating the readme and/or gemfile to list the language requirement. As you said, projects should upgrade by now, so this should fall on them, not you. I was using BlueHydra earlier on a Raspberry Pi with minimal configuration and noticed an issue on their end (sort of) from this. Raspberry Pi installs Ruby 2.3.3 by default with |
Happy to help! Glad this solution worked out. I will update the gemspec definition with a minimal Ruby version but that is likely much lower now (can't hurt right?). I'll throw that on my TODO list for tomorrow but for now as it seems to have solved your issue I'm going to close this ticket. Even if you're only indirectly using my gem I appreciate the time you took to identify and report the issue. It's always nice to know your code is being used hahah. |
As of release 2.0.8, Louis utilizes functionality only available in Ruby >2.4.0. The required minimum language should be updated to reflect this.
This is due (at least in part) to the use of
Hash#compact
in lib/louis.rb on lines 35 and 40, an attribute not added to Ruby until 2.4.0. See related thread for BlueHydra pwnieexpress/blue_hydra#131.The text was updated successfully, but these errors were encountered: