You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Over on the https://github.com/ssciwr/clang-tidy-wheel I've run into trouble testing the binary that's shipped with the wheel.
The get_executable stuff in the package does not append .exe on windows. If we use subprocess.run on the resulting absolute path that fails. If you use subprocess.run just on the command name and rely on it being in PATH, windows will silently add .exe. I've found this out because in the test I use something like
Note that in the format tests here, the command name form is used. In fact the clang_format package is never imported.
This might execute the right binary, but depends on ordering in PATH. clang-format is also installed in the windows base image.
I suspect the situation on MacOS might be similar if the build results in a clang-tidy.{bin,dmg}, but haven't checked yet.
I think using the full absolute path in the tests is the correct way to do it. And once I got it all fixed on the tidy side, I would PR a matching update here.
The text was updated successfully, but these errors were encountered:
The resulting binaries that actually get run on macOS don't have an extension. (.dmg is a disk image and sort of acts like a zip/tar archive for distributing apps; .app is just a folder whose contents have a special structure; .pkg is an installer)
Over on the https://github.com/ssciwr/clang-tidy-wheel I've run into trouble testing the binary that's shipped with the wheel.
The
get_executable
stuff in the package does not append.exe
on windows. If we usesubprocess.run
on the resulting absolute path that fails. If you usesubprocess.run
just on the command name and rely on it being in PATH, windows will silently add.exe
. I've found this out because in the test I use something likeNote that in the format tests here, the command name form is used. In fact the
clang_format
package is never imported.This might execute the right binary, but depends on ordering in PATH.
clang-format
is also installed in the windows base image.I suspect the situation on MacOS might be similar if the build results in a
clang-tidy.{bin,dmg}
, but haven't checked yet.I think using the full absolute path in the tests is the correct way to do it. And once I got it all fixed on the tidy side, I would PR a matching update here.
The text was updated successfully, but these errors were encountered: