Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reindexEncrypted() should auto-resume after a crash #419

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

reindexEncrypted() should auto-resume after a crash #419

wants to merge 4 commits into from

Conversation

staltz
Copy link
Member

@staltz staltz commented Jan 31, 2023

For issue #407

@staltz staltz linked an issue Jan 31, 2023 that may be closed by this pull request
reindexEncrypted needs to be crash-resistant #407
Open
arj03
arj03 reviewed Jan 31, 2023
View reviewed changes
test/reindex-encrypted.js Outdated Show resolved Hide resolved
@staltz
Copy link
Member Author

staltz commented Jan 31, 2023

Not sure why tests don't pass in CI, but pass locally for me, both Node 16 and 18...

@arj03
Copy link
Member

arj03 commented Feb 2, 2023

I did a checkout and ran the tests to see and fails here with:

   ✖ 645) bob has two box2 mentions from alice
      Expected 2 but got 0
      At: Test.<anonymous> (/test/reindex-encrypted.js:334:5)

On node 17.5

@staltz staltz self-assigned this Mar 2, 2023
@staltz staltz closed this Mar 2, 2023
@staltz staltz reopened this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arj03 arj03 arj03 left review comments

Assignees

@staltz staltz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reindexEncrypted needs to be crash-resistant
2 participants
@staltz @arj03