Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Replace CommunicationError with more specific error types #839

Open
raccube opened this issue Dec 3, 2022 · 2 comments
Open

Replace CommunicationError with more specific error types #839

raccube opened this issue Dec 3, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers semver-minor This change requires an increment in the minor version number

Comments

@raccube
Copy link
Member

raccube commented Dec 3, 2022

Using ComminicationError everywhere isn't particularly detailed and could be improved by creating specific error types for each occurrance. This would potentially allow for users to implement better error handling if a method returns multiple errors.
@raccube raccube added enhancement New feature or request good first issue Good for newcomers semver-minor This change requires an increment in the minor version number labels Dec 3, 2022
@ShaziahGafur
Copy link

ShaziahGafur commented Dec 4, 2022 •
edited
Loading

Hi @raccube, I can work on this. Please assign it to me

@trickeydan
Copy link
Contributor

Hi @raccube, I can work on this. Please assign it to me

Hi @ShaziahGafur, that sounds great! I've assigned this issue to you. If you have any questions please just ask :)

Please could you make sure that any new exception classes inherit from CommunicationError so that the changes aren't breaking? Thanks!

@ShaziahGafur ShaziahGafur removed their assignment Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers semver-minor This change requires an increment in the minor version number
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@raccube @trickeydan @ShaziahGafur