Fix github CI #85
Merged
Fix github CI #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Mori <[email protected]>
vmarkovtsev
approved these changes
Jun 19, 2024
|
This is awesome! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current github CI is broken and it is preventing to upload new versions of lapjv to pypi.
After introducing #84 lapjv is now incompatible with Cpython 3.8 (because there is no numpy >= 2.0 that has been released for Cpython 3.8), this is why I removed it from the cibuildwheel list. I don't think it's a huge deal as python 3.8 will reach EOL in just a few months (see https://devguide.python.org/versions/), and older versions of lapjv will still be out there for folks that need python 3.8 support.