Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osfs should implement billy.Changer #56

Open
rydrman opened this issue Apr 4, 2018 · 3 comments
Open

osfs should implement billy.Changer #56

rydrman opened this issue Apr 4, 2018 · 3 comments

Comments

@rydrman
Copy link

rydrman commented Apr 4, 2018

I have been loving this abstraction that you guys have created so kudos to that! Trying to change the permissions on a file using the osfs but it seems that it doesn't implement the billy.Changer interface. I was looking into making some changes for this but the relationship between the osfs.OS type and the chroot seems to mess it up a little since I guess we don't want the ChrootHelper to assume the given underlying fs is a changer... Any insight into how I might go about this would be greatly appreciated.

@smola
Copy link
Contributor

smola commented Aug 1, 2018

@rydrman It can always implement the function and return ErrNotSupported if the underlying filesystem does not support it.

@mcuadros what do you think?

@mcuadros
Copy link
Contributor

If we add Change interface to Filesystem will force 3rd party implementation change

@ajnavarro
Copy link
Contributor

Not add Change into Filesystem interface, but implement Changer interface on osfs implementation will not break backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants