-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Q.Volt HYB-G3-1P #95
base: master
Are you sure you want to change the base?
Conversation
- TODO: Discovery gets stuck and times out at X3???
Get rid of the inverter discovery debug line
Thanks for raising this PR! Once the checks are green I'll swing back and have a look |
@squishykid Well, it's been a while. I'm a bit of a noob when it comes to automated checks, not sure if I need to do anything else to trigger a new round... |
Anything else to do here? I still haven't figured out if I need to do something in particular to trigger a new round of checks 😅 I'd like to see it bundled in one of the next releases bundled with Home Assistant, because after the latest update I'm somehow unable to override the official library version with my own... |
If resolving the conflicts doesn't cause the checks to run then it is fine to create a new (duplicate) PR. |
Uh, almost there... I'm not brave enough to find a compliant solution for this, considering the inverter I'm adding is very close to its 3-phase G3-3P sibling and it makes sense it looks almost identical outside of the crude parameter map. I guess |
Interestingly enough the line |
See #94 for some more details.
What happened here?
to_signed32
) to read certain registers