Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Q.Volt HYB-G3-1P #95

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

TheRealZago
Copy link

See #94 for some more details.

What happened here?

  • Added Q.Volt HYB-G3-1P data structure parser (almost copy-pasted from HYB-G3-3P)
  • Added a couple new units and modifiers (eg, to_signed32) to read certain registers
  • Added test fixtures with reference responses

@squishykid
Copy link
Owner

Thanks for raising this PR! Once the checks are green I'll swing back and have a look

@TheRealZago
Copy link
Author

@squishykid Well, it's been a while. I'm a bit of a noob when it comes to automated checks, not sure if I need to do anything else to trigger a new round...

@TheRealZago
Copy link
Author

Anything else to do here? I still haven't figured out if I need to do something in particular to trigger a new round of checks 😅

I'd like to see it bundled in one of the next releases bundled with Home Assistant, because after the latest update I'm somehow unable to override the official library version with my own...

@Darsstar
Copy link
Contributor

Darsstar commented Apr 2, 2024

If resolving the conflicts doesn't cause the checks to run then it is fine to create a new (duplicate) PR.

@TheRealZago
Copy link
Author

TheRealZago commented Apr 25, 2024

Uh, almost there...
Checks are failing on pylint because of duplicate-code / R0801.

I'm not brave enough to find a compliant solution for this, considering the inverter I'm adding is very close to its 3-phase G3-3P sibling and it makes sense it looks almost identical outside of the crude parameter map.

I guess R0801 could be ignored as well, but I don't know if it could have undesired side-effects on the long run.

setup.py Outdated Show resolved Hide resolved
solax/inverters/qvolt_hyb_g3_1p.py Outdated Show resolved Hide resolved
@Darsstar
Copy link
Contributor

I guess R0801 could be ignored as well, but I don't know if it could have undesired side-effects on the long run.

# pylint: disable=duplicate-code occurs 10 times already. So go ahead.

Interestingly enough the line # pylint: enable=duplicate-code only occurs 6 times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants