Fix/x3 hybrid g4 run mode #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Th3Link
force-pushed
the
fix/x3-hybrid-g4-run-mode-id
branch
2 times, most recently
from
c4a1b50
to
5dbe5e4
Compare
HA uses the field index as ids for the sensors, hence it must not occur twice.
Th3Link
force-pushed
the
fix/x3-hybrid-g4-run-mode-id
branch
2 times, most recently
from
c8b756a
to
75420cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am in progress of implementing the x3 ultra, I got some issues in HA, especially double ids breaks the sensor mapping. I'd like it better to add an additional id or generate it from the name, but that would break the sensor ids for everyone...