Add Leave context entry & PART completion #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperstorm
approved these changes
Jun 29, 2023
casperstorm
force-pushed
the
feat/nicklist-context
branch
2 times, most recently
from
7a50ab2
to
44ce5a7
Compare
Add leave for server Add Leave context entry & PART completion Always pointer for context menu Add user context to user nicks in buffer Keep input module locked down Refactor to nick_list module Snap context menu to viewport Update mouse interaction for context menu nicklist context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new context entry to leave a server / channel / query.
If leaving a server, it sends QUIT and drops the connection. I've confirmed via
lsofthe underlying connection is killed.If leaving a channel, it sends a PART.
If leaving a query, nothing is sent but the buffer is closed.
In all cases the associated history is cleanly flushed and removed. Side menu properly doesn't show entries anymore.