Dynamic change theme based on OS appearance #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperstorm
force-pushed
the
feat/light-dark
branch
from
9f71765
to
f51c956
Compare
casperstorm
force-pushed
the
feat/light-dark
branch
from
a35c56f
to
01d771c
Compare
tarkah
approved these changes
Sep 23, 2024
data/src/appearance.rs
Outdated
Comment on lines
33
to
40
| pub fn new(first: Theme, second: Option<Theme>) -> Selected { | ||
| match second { | ||
| Some(second) => Selected::Dynamic { | ||
| light: first, | ||
| dark: second, | ||
| }, | ||
| None => Selected::Static(first), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: It might be nice to instead have separate constructors: Selected::static vs Selected::dynamic(light: Theme, dark: Theme) and then call-site determines which is used.
There was a problem hiding this comment.
Fixing this before i merge.
casperstorm
force-pushed
the
feat/light-dark
branch
from
5cd1ae8
to
a83f0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
themeconfiguration key to take alightand adarkvariant. Doing so will enable a Halloy to dynamically pick theme based on OS appearance.Statically setting a theme, works like before: