Add password_command config option
#552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e554c4c
force-pushed
the
password_command
branch
from
e11f502
to
8ed72c6
Compare
4e554c4c
added a commit
to 4e554c4c/halloy
that referenced
this pull request
Sep 13, 2024
Fixes squidowl#551 Needed for squidowl#552, squidowl#424
4e554c4c
added a commit
to 4e554c4c/halloy
that referenced
this pull request
Sep 13, 2024
Fixes squidowl#551 Needed for squidowl#552, squidowl#424 Test plan: 1) open halloy 2) test reloading config 3) apply patches in squidowl#552 4) observe that UI operates while long-running command is blocking the config from reloading
4e554c4c
added a commit
to 4e554c4c/halloy
that referenced
this pull request
Sep 13, 2024
Fixes squidowl#551 Needed for squidowl#552, squidowl#424 Test plan: 1) open halloy 2) test reloading config 3) apply patches in squidowl#552 4) observe that UI operates while long-running command is blocking the config from reloading
4e554c4c
added a commit
to 4e554c4c/halloy
that referenced
this pull request
Sep 13, 2024
Fixes squidowl#551 Needed for squidowl#552, squidowl#424 Test plan: 1) open halloy 2) test reloading config 3) apply patches in squidowl#552 4) observe that UI operates while long-running command is blocking the config from reloading
tarkah
reviewed
Sep 13, 2024
4e554c4c
added a commit
to 4e554c4c/halloy
that referenced
this pull request
Sep 13, 2024
Fixes squidowl#551 Needed for squidowl#552, squidowl#424 Test plan: 1) open halloy 2) test reloading config 3) apply patches in squidowl#552 4) observe that UI operates while long-running command is blocking the config from reloading
4e554c4c
force-pushed
the
password_command
branch
from
8ed72c6
to
1523e5b
Compare
tarkah
force-pushed
the
password_command
branch
from
1523e5b
to
a302531
Compare
tarkah
approved these changes
Sep 16, 2024
4e554c4c
added a commit
to 4e554c4c/halloy
that referenced
this pull request
Sep 20, 2024
This commit builds off of squidowl#552 and allows the user to supply a command instead of a password file anywhere that a password file is used. If the password command ends unsuccessfully, then an error is displayed. Trailing whitespace is now trimmed from password commands, as it is commonplace for commands to leave a trailing newline after the password they output. Resolves squidowl#580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #424
related to #551 but I don't think that fix should be done in this PR, since it the changes involved are largely orthogonal to this one.