-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notifications (and windows msi installer) #163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperstorm
force-pushed
the
feat/notifications
branch
4 times, most recently
from
July 21, 2023 20:00
d4befb0
to
b9917ac
Compare
casperstorm
force-pushed
the
feat/notifications
branch
from
July 31, 2023 19:22
b9917ac
to
9438bbf
Compare
tarkah
force-pushed
the
feat/notifications
branch
2 times, most recently
from
August 2, 2023 19:00
9e9d438
to
0eef0ff
Compare
@tarkah what do you think we should add before merge?
|
Closed
casperstorm
force-pushed
the
feat/notifications
branch
from
September 11, 2023 20:20
0eef0ff
to
3372de5
Compare
tarkah
reviewed
Sep 18, 2023
tarkah
reviewed
Sep 18, 2023
tarkah
reviewed
Sep 19, 2023
tarkah
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds notification support, along a few events:
Connected
,Reconnected
andDisconnected
.We should add more, but for now the base should be ready.
Reason this PR also includes a new installer for Windows is that in order to get a icon on the notification on Windows we need a
app_id
, and the easiest way (that i know of) is to do it through a.wxs
file. For that reason we might as well produce a.msi
installer as our "primary" windows installation. Going forward we could then use a default.exe
asset for our "portable" installer (#141) - this would then be similar to how Alacritty does releases and assets.In any case, with the app installed through the
.msi
installer notifications has a small icon which looks great.Sounds
The configuration can take a string to a sound. Each OS has a different set of default sounds, depending on OS version as well. However in order for the user to know what to pick, we need to make a entry to our wiki with the different defaults and how to find them (see below).
This entire branch is currently untested on Linux - @tarkah could you test this?
macOS (
/System/Library/Sounds/
)Windows (https://github.com/allenbenz/winrt-notification/blob/main/src/lib.rs#L70-L75)
Unix (https://github.com/hoodie/notify-rust/blob/main/src/hints.rs#L68)
Fixes #203