We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RedisIndexedSessionRepository and RedisSessionExpirationPolicy create a lot of single-use proxies by relying on BoundHashOperations.
RedisIndexedSessionRepository
RedisSessionExpirationPolicy
BoundHashOperations
For instance in this case:
spring-session/spring-session-data-redis/src/main/java/org/springframework/session/data/redis/RedisIndexedSessionRepository.java
Lines 898 to 903 in f6f4c86
Lines 733 to 735 in f6f4c86
This showed up in our production profiler because of hundreds of MB allocated in java.lang.reflect.Method:
java.lang.reflect.Method
If I understand the code correctly, this is done purely for convenience and could simply be replaced by the following code:
String key = getSessionKey(sessionId); sessionRedisOperations.opsForHash().putAll(key, this.delta);
Or am I overlooking something?
The text was updated successfully, but these errors were encountered:
No branches or pull requests
RedisIndexedSessionRepository
andRedisSessionExpirationPolicy
create a lot of single-use proxies by relying onBoundHashOperations
.For instance in this case:
spring-session/spring-session-data-redis/src/main/java/org/springframework/session/data/redis/RedisIndexedSessionRepository.java
Lines 898 to 903 in f6f4c86
spring-session/spring-session-data-redis/src/main/java/org/springframework/session/data/redis/RedisIndexedSessionRepository.java
Lines 733 to 735 in f6f4c86
This showed up in our production profiler because of hundreds of MB allocated in
java.lang.reflect.Method
:If I understand the code correctly, this is done purely for convenience and could simply be replaced by the following code:
Or am I overlooking something?
The text was updated successfully, but these errors were encountered: