Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve caching of requestedSession #3063

Open
marcusdacoregio opened this issue Jun 25, 2024 · 0 comments
Open

Improve caching of requestedSession #3063

marcusdacoregio opened this issue Jun 25, 2024 · 0 comments
Assignees
Labels
in: core type: enhancement A general enhancement
Milestone

Comments

@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Jun 25, 2024

As of now, the requestedSession is cached as a field in the request wrapper.

The majority of servlet containers recycle their request objects and return them to the pool for reuse. Since the requestedSession is stored in the wrapper level (not as an request attribute like currentSession), it won't be recycled.
We should improve this in a way that when the request is recycled, the requestedSession is also "cleared".

Thanks @swendlandt for the help identifying this improvement.

@marcusdacoregio marcusdacoregio self-assigned this Jun 25, 2024
@marcusdacoregio marcusdacoregio added this to the 3.4.0-M1 milestone Jul 8, 2024
@marcusdacoregio marcusdacoregio modified the milestones: 3.4.0-M1, 3.4.0-M2 Jul 16, 2024
@marcusdacoregio marcusdacoregio modified the milestones: 3.4.0-M2, 3.4.0-M3 Aug 20, 2024
@rwinch rwinch modified the milestones: 3.4.0-M3, 3.4.0-RC1 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants