Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add database indexes in schema files. #411

Closed
wants to merge 1 commit into from
Closed

Add database indexes in schema files. #411

wants to merge 1 commit into from

Conversation

maciejwalkowiak
Copy link
Contributor

Fixes #403

maciejwalkowiak
maciejwalkowiak commented Dec 8, 2023
View reviewed changes
spring-modulith-events/spring-modulith-events-jdbc/src/main/resources/schema-mysql.sql
PRIMARY KEY (ID)
)
PRIMARY KEY (ID),
INDEX EVENT_PUBLICATION_LISTENER_ID_IDX (LISTENER_ID),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SERIALIZED_EVENT cannot be a part of index key as MySQL accepts only 3072 bytes.

@maciejwalkowiak
Copy link
Contributor Author

Adding indexes to HSQLDB is failing with: user lacks privilege or object not found. Not sure why. I am also not sure about index naming, perhaps @odrotbohm you can come up with more meaningful names.

@odrotbohm
Copy link
Member

Adding indexes to HSQLDB is failing with: user lacks privilege or object not found. Not sure why. I am also not sure about index naming, perhaps @odrotbohm you can come up with more meaningful names.

This seems to have been caused by our schema execution sending the entire content of the files as one go, and HSQLDB doesn't deal with that properly. I've filed GH-507 to improve on the execution, which subsequently makes the index declarations work on HSQLDB, too.

odrotbohm pushed a commit that referenced this pull request Feb 20, 2024
@maciejwalkowiak @odrotbohm
GH-403 - Add database indexes in schema files.
f440af9 
Original pull request: GH-411.
odrotbohm added a commit that referenced this pull request Feb 20, 2024
@odrotbohm
GH-403 - Polishing.
840a1b6 
Added indexes for HSQLDB (after fix for GH-507). Removed by-listener index for MySQL as it would not be used anyway. Polished index names. Disable Spring Boot banners in tests.

Original pull request: GH-411.
@odrotbohm odrotbohm mentioned this pull request Feb 20, 2024
Closed
@odrotbohm odrotbohm closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add indexes to event_publication tables
2 participants
@maciejwalkowiak @odrotbohm