Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParameterBindingJsonReader doesn't consider regex options #4806

Closed
Cimballi opened this issue Oct 10, 2024 · 0 comments
Closed

ParameterBindingJsonReader doesn't consider regex options #4806

Cimballi opened this issue Oct 10, 2024 · 0 comments
Assignees
@mp911de
Labels
type: bug A general bug
Milestone
4.2.11 (2023.1.11)

Comments

@Cimballi
Copy link

Cimballi commented Oct 10, 2024 •
edited
Loading

It looks like the following query doesn't take the options "i" into account
@query = { 'a': 'b', 'c': /^true$/i }

in the logs = { "a" : "b", "c" : { "$regularExpression" : { "pattern" : "^true$", "options" : ""}}}
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 10, 2024
@mp911de mp911de self-assigned this Oct 11, 2024
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 11, 2024
@mp911de mp911de changed the title Query with pattern + options doesn't take options into account ParameterBindingJsonReader doesn't consider regex options Oct 11, 2024
mp911de added a commit that referenced this issue Oct 11, 2024
@mp911de
Retain Regex options from the parsed JsonToken.
624dcf0 
We now retain BsonRegularExpression.options when resolving bind values from the original BsonRegularExpression.

Closes #4806
@mp911de mp911de mentioned this issue Oct 11, 2024
Closed
christophstrobl pushed a commit that referenced this issue Oct 15, 2024
@mp911de @christophstrobl
Retain regex options from the parsed JsonToken.
dc1bd84 
We now retain expression options when resolving bind values from the original BsonRegularExpression.

Closes: #4806
Original Pull Request: #4807
christophstrobl pushed a commit that referenced this issue Oct 15, 2024
@mp911de @christophstrobl
Retain regex options from the parsed JsonToken.
0561b80 
We now retain expression options when resolving bind values from the original BsonRegularExpression.

Closes: #4806
Original Pull Request: #4807
@christophstrobl christophstrobl added this to the 4.2.11 (2023.1.11) milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: bug A general bug
Projects
None yet
Milestone
4.2.11 (2023.1.11)
Development

Successfully merging a pull request may close this issue.

Retain Regex options from the parsed JsonToken spring-projects/spring-data-mongodb
4 participants
@Cimballi @mp911de @christophstrobl @spring-projects-issues