Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json deserialization of multi-valued authorization request parameters #1676

Closed
wants to merge 1 commit into from

Conversation

MrJovanovic13
Copy link
Contributor

@MrJovanovic13 MrJovanovic13 commented Jul 22, 2024

I have tested this mixin on a sample spring authorization server app, by registering the mixin on a custom JdbcOAuth2AuthorizationService bean.

Authorization flow now works correctly without throwing on multi valued parameters. String[] is correctly serialized & deserialized.

Closes gh-1666

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 22, 2024
@MrJovanovic13 MrJovanovic13 force-pushed the gh-1666 branch 2 times, most recently from f6830f9 to c18e8b3 Compare July 22, 2024 23:07
@jgrandja jgrandja changed the title Register String[] mixin Fix json deserialization of multi-valued authorization request parameters Jul 31, 2024
@jgrandja jgrandja self-assigned this Jul 31, 2024
@jgrandja jgrandja added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 31, 2024
@jgrandja jgrandja added this to the 1.2.6 milestone Jul 31, 2024
@jgrandja
Copy link
Collaborator

Thanks for the fix @MrJovanovic13 ! This is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants