Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add how-to guide for dynamic client registration with custom metadata #1376

Closed
wants to merge 1 commit into from
Closed

Add how-to guide for dynamic client registration with custom metadata #1376

wants to merge 1 commit into from

Conversation

ddubson
Copy link
Contributor

@ddubson ddubson commented Sep 29, 2023

Fixes gh-1044

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 29, 2023
@jgrandja jgrandja self-assigned this Oct 16, 2023
@jgrandja jgrandja added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 16, 2023
@jgrandja jgrandja added this to the 1.2.0 milestone Oct 16, 2023
@jgrandja jgrandja added the status: duplicate A duplicate of another issue label Oct 16, 2023
jgrandja
jgrandja requested changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ddubson. Please see review comment.

docs/src/main/java/sample/registration/custommetadata/CustomMetadataConfig.java Outdated Show resolved Hide resolved
@ddubson ddubson marked this pull request as draft October 31, 2023 13:46
@ddubson ddubson force-pushed the ddubson/issue-1044/how-to/customize-client-metadata-dcr branch from b98bbce to 1358a04 Compare October 31, 2023 13:46
@ddubson ddubson force-pushed the ddubson/issue-1044/how-to/customize-client-metadata-dcr branch from 1358a04 to b964893 Compare November 9, 2023 16:09
@ddubson ddubson marked this pull request as ready for review November 9, 2023 16:09
@ddubson
Copy link
Contributor Author

ddubson commented Nov 9, 2023

@jgrandja -- I've condensed the custom metadata section into the main body of the content -- hopefully it's not too visually busy in the middle section where all the Converters are depicted. Ready for formal review!

@jgrandja jgrandja added type: enhancement A general enhancement and removed status: duplicate A duplicate of another issue type: documentation A documentation update labels Nov 16, 2023
jgrandja added a commit that referenced this pull request Nov 16, 2023
@jgrandja
Polish gh-1376
74058e5
@jgrandja
Copy link
Collaborator

Thanks for the updates @ddubson ! This is now merged and I followed it up with a polish commit.

@jgrandja jgrandja closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandja jgrandja Awaiting requested review from jgrandja

Assignees

@jgrandja jgrandja

Labels
type: enhancement A general enhancement
Projects
Spring Security Team
Status: Done
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

How-to: Customize client metadata during dynamic client registration
3 participants
@ddubson @jgrandja @spring-projects-issues