Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CodeVerifierAuthenticator public #1352

Open
Vojtech-Sassmann opened this issue Sep 5, 2023 · 0 comments
Open

Make CodeVerifierAuthenticator public #1352

Vojtech-Sassmann opened this issue Sep 5, 2023 · 0 comments
Labels
type: enhancement A general enhancement

Comments

@Vojtech-Sassmann
Copy link

Expected Behavior
The CodeVerifierAuthenticator is public and can be used in custom AuthenticationProviders.

Current Behavior
The CodeVerifierAuthenticator is package-private and cannot be used outside this package.

Context
We are implementing a custom AuthenticationProvider which uses client X509 certificate. We also would like to use PKCE inside this AuthenticationProvider. We cannot simply reuse the CodeVerifierAuthenticator because its visibility is restricted. We must either write custom PKCE validation and duplicate the logic or create the custom AuthenticationProvider inside the same package as the CodeVerifierAuthenticator.

Related PR: #1348

@Vojtech-Sassmann Vojtech-Sassmann added the type: enhancement A general enhancement label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant