Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete '/' at the end of url #1037

Closed
wants to merge 3 commits into from
Closed

Delete '/' at the end of url #1037

wants to merge 3 commits into from
+11 −2

Commits on Jun 21, 2024

  1. fix: remove last slash of url

    @birariro
    birariro committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7bc2254 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. code rollback

    @birariro
    birariro committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    e067fdf View commit details
    Browse the repository at this point in the history

  2. Delete '/' at the end of url 

    In situation when we create FeignClient in this way:
@FeignClient(url = "https://localhost/", path = "api/v2")
We will get an error because of adding '/' in the beginning of the path in FeignClientsRegistrar.getPath, result will:
https://localhost//api/v2
To escape this situation we need to delete '/' at the end of url in FeignClientsRegistrar.getUrl
    @artem-gorshkov @birariro
    artem-gorshkov authored and birariro committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3b1d272 View commit details
    Browse the repository at this point in the history