Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service instance labeling #348

Open
zoharyehezkely opened this issue Apr 12, 2022 · 9 comments
Open

Service instance labeling #348

zoharyehezkely opened this issue Apr 12, 2022 · 9 comments

Comments

@zoharyehezkely
Copy link

Hi,

Following this issue: https://github.com/spring-cloud/spring-cloud-open-service-broker/issues/311
Regarding support for the labeling service instances.
I saw that in OSB master, fetching a Service Instance returns also the metadata
https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#fetching-a-service-instance

Is this implementation planned for the next release?

Thanks,
Zohar.

@zoharyehezkely
Copy link
Author

Hi,

I have an implementation ready here:
zoharyehezkely@f765069

Can someone assist with merging it to master?
Thanks,
Zohar.

@zoharyehezkely
Copy link
Author

I have created a PR here:
#349

@royclarkson
Copy link
Member

@zoharyehezkely thanks for the PR. It appears that change to the response body for fetching a service instance is not part of OSB API 2.16. Because it hasn't been released as part of a versioned specification, we can't include yet. Anything that is unreleased in master can potentially change, even if unlikely. We'll be happy to merge this once it is included in a released spec.

@zoharyehezkely
Copy link
Author

@royclarkson - Any idea when the next OSB release is due?

Thanks,
Zohar.

@zoharyehezkely
Copy link
Author

zoharyehezkely commented Jul 6, 2022

Hi @royclarkson,
There is a PR for OSB API 2.17 waiting for reviewers:
openservicebrokerapi/servicebroker#751
I was told there are 2 people on the committee from vmware.
Can you check from your side if it is possible to notify them for assistance here?

Thanks,
Zohar.

@zoharyehezkely
Copy link
Author

Hi @royclarkson
OSB 2.17 has been released.
https://github.com/openservicebrokerapi/servicebroker/tree/v2.17

Regards,
Zohar.

@zoharyehezkely
Copy link
Author

zoharyehezkely commented Sep 4, 2022

Hi,

Any updates on this issue?

Regards,
Zohar.

@zoharyehezkely
Copy link
Author

Hi @royclarkson
Any new updates on this issue?

Thanks,
Zohar.

@royclarkson
Copy link
Member

@zoharyehezkely we have to finalize the OSB 2.16 support first in a release, and then I'll get this added for future 2.17 support. It will probably be a version 4.1. Thanks for your patience.

@royclarkson royclarkson added this to the 4.1.0-M1 milestone Nov 29, 2022
@royclarkson royclarkson removed this from the 4.1.0-M1 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants