Fix #gh-4094. #4308
Open
Fix #gh-4094. #4308
+97
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns of InstanceStatus Implement semaphore synchronization to prevent concurrent modifications of InstanceStatus - Added a Semaphore to control concurrent access to InstanceStatus modifications. - Modified EurekaClientConfigurationRefresher to acquire the semaphore before performing deregister and register operations. - Modified DiscoveryClientConfiguration to acquire the semaphore before performing refreshInstanceInfo operations. - Ensured the semaphore is released in a finally block to handle exceptions properly. This change addresses the issue of concurrent modifications of InstanceStatus, ensuring that only one thread can modify the status at a time.
|
Hello @bazzop, thanks for submitting the PR. This looks like a duplicate of #4301. Please pick one and close the other or -preferably- close both and open a new one against the |
|
Ok, I see this is very fresh, so probably you're addressing my comments on the go :). Please keep one active PR in this repo though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.