Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudFoundry task launch test #453

Open
onobc opened this issue May 17, 2024 · 0 comments
Open

Add CloudFoundry task launch test #453

onobc opened this issue May 17, 2024 · 0 comments
Milestone

Comments

@onobc
Copy link
Contributor

onobc commented May 17, 2024

Recently commons-compress was updated to 1.26.x (here) which requires commons-io:2.15.1

This was not noticed in the deployer CI but rather surfaced down in the Cloud Foundry ATs as an obscure NoClassDefFoundError (nobody likes that).

Doing a basic task launch (timestamp) resulted in:

2024-05-16T13:53:50.21-0500 [APP/PROC/WEB/0] OUT java.lang.NoClassDefFoundError: org/apache/commons/io/build/AbstractStreamBuilder
2024-05-16T13:53:50.21-0500 [APP/PROC/WEB/0] OUT at org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:858) ~[commons-compress-1.26.0.jar:1.26.0]
2024-05-16T13:53:50.21-0500 [APP/PROC/WEB/0] OUT at org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:930) ~[commons-compress-1.26.0.jar:1.26.0]
2024-05-16T13:53:50.21-0500 [APP/PROC/WEB/0] OUT at org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:818) ~[commons-compress-1.26.0.jar:1.26.0]
2024-05-16T13:53:50.21-0500 [APP/PROC/WEB/0] OUT at org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:794) ~[commons-compress-1.26.0.jar:1.26.0]
2024-05-16T13:53:50.21-0500 [APP/PROC/WEB/0] OUT at org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:714) ~[commons-compress-1.26.0.jar:1.26.0]
2024-05-16T13:53:50.21-0500 [APP/PROC/WEB/0] OUT at org.apache.commons.compress.archivers.zip.ZipFile.(ZipFile.java:701) ~[commons-compress-1.26.0.jar:1.26.0]
2024-05-16T13:53:50.21-0500 [APP/PROC/WEB/0] OUT at org.cloudfoundry.util.ResourceMatchingUtils.getArtifactMetadataFromZip(ResourceMatchingUtils.java:80)

We should see if we can mock CloudFoundry out and add a test for this here in this repo because things are harder to diagnose the further up the testing pyramid. If we can't mock it and it truly needs CF available to test this, that is fine.

FYI - this was the commit that fixed the issue 310f4fd

@onobc onobc added this to the 2.9.x milestone May 17, 2024
@onobc onobc changed the title Add basic CloudFoundry deploy test Add CloudFoundry task launch test May 17, 2024
@cppwfs cppwfs modified the milestones: 2.9.x, 3.0.x Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants