Modify the getServices() method so that it filters on default-query-tag #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the default query tag if it is set
|
@fuleow Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
…the default query tag if it is set
spencergibb
requested changes
Dec 13, 2018
...iscovery/src/main/java/org/springframework/cloud/consul/discovery/ConsulDiscoveryClient.java
Show resolved
Hide resolved
|
Do changes of these nature fall under "obvious fix" or does it require signing the ICLA? |
|
Since it is a change in functionality or behavior, it requires the CLA |
|
@fuleow Thank you for signing the Contributor License Agreement! |
|
In Finchley, this method is useless, I don't know why catalogservice was called frequently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
ConsulDiscoveryClientso that itsgetServices()method takes into account the value ofdefault-query-tagif it is set.Further details are available in issue #452.