This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
Fix cachefrom option to work correctly #317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the cacheFrom build option, which pulls a Docker image to use it for the build cache doesn't seem to be working. It pulls the image and says it will use the image for the build cache, but it doesn't actually get used. This PR fixes it.
https://docs.docker.com/engine/api/v1.40/#operation/ImageBuild
According to the Docker engine API docs it should be passed in as "cachefrom" and does not need to be encoded, just as a JSON list.
This fix is crucial when building on serverless hosts, since images end up being rebuilt without the build cache which takes extra time, and it also ends up taking extra space when pushing the image to a Docker registry.