Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some "metrics" being reported as dimensions #918

Closed
M-Bates opened this issue Nov 17, 2023 · 9 comments
Closed

Some "metrics" being reported as dimensions #918

M-Bates opened this issue Nov 17, 2023 · 9 comments

Comments

@M-Bates
Copy link

M-Bates commented Nov 17, 2023

A number of data types that are the same as Gauge or Counter are currently being extracted as dimensions rather than metrics.
The data types are defined in the IETF textual conventions files, HCNUM-TC

  • CounterBasedGauge64
  • ZeroBasedCounter64

Screenshot 2023-11-17 111421

@ajasnosz
Copy link
Collaborator

The values you mention as CounterBasedGauge64 are jnxJsNodeSessionCreationPerSecond and jnxJsNodeSessCreationPerSecIPv4 in this mib, I don't see any ZeroBasedCounter64, are there any of this type? Were they presented as metrics before? Could you show how they look like without using sc4snmp?

@M-Bates
Copy link
Author

M-Bates commented Nov 20, 2023

The values for the 3 CounterBasedGuauge64 from the Juniper MIB has always been interpreted as a dim rather than metric

  • jnxJsNodeSessCreationPerSecIPv4: 13
  • jnxJsNodeSessCreationPerSecIPv6: 0
  • jnxJsNodeSessionCreationPerSecond: 13

snmpget -v 2c -c <> -m +JUNIPER-SRX5000-SPU-MONITORING-MIB <>.1.3.6.1.4.1.2636.3.39.1.12.1.4.1.5.0
JUNIPER-SRX5000-SPU-MONITORING-MIB::jnxJsNodeSessionCreationPerSecond.0 = Counter64: 3

Unfortunately, these are the only 3 CounterBasedGuage metrics being collected across all device types.

@ajasnosz
Copy link
Collaborator

If they were always interpreted as dim then it is what we expect, as this depends on mib and pysnmp library. We don't have any exceptions that we apply when translating, it's all automatically translated.

@M-Bates
Copy link
Author

M-Bates commented Nov 28, 2023

I cannot tell you whether they were always wrong.
What I can say is that they are wrong now, and need to be correctly sent as metric points not dimensions. This is also a function of this library, not pysnmp.

As requested, please fix the issue with the 2 data types being sent as dimensions rather than metric values.
This is a breaking issue as there is no way to consistently graph the values of dimensions over time for large volumes of data.

@ajasnosz
Copy link
Collaborator

I've prepared the image for sc4snmp with the code that might fix this. We don't have the devices with types you mentioned, so you can test the changes by adding below lines to the values.yaml and running the upgrade command. Let us know if this solution is changing the CounterBasedGuauge64 and ZeroBasedCounter64 to metrics.

image:
  # The registry and name of the SC4SNMP image to pull
  repository: ajasnosz558/sc4snmp-dev-hostname
  # The policy that specifies when the user wants the SC4SNMP images to be pulled
  pullPolicy: Always
  # Overrides the image tag whose default is the chart appVersion.
  tag: "new-metrics"

@ajasnosz
Copy link
Collaborator

@M-Bates did you have time to test above image?

@M-Bates
Copy link
Author

M-Bates commented Dec 20, 2023

Not as yet. The customer has been in a change freeze. I should the ability to test it around mid-Jan.

@ajasnosz
Copy link
Collaborator

@M-Bates was the image tested and is working fine?

@M-Bates
Copy link
Author

M-Bates commented May 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants