move edgeConfigClient outside of handler #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edge config should be created outside of the handler. You might even want to move the whole SplitFactory client outside of the handler in case it makes sense to remove those across requests, or maybe just the PluggableStorage or the EdgeConfigWrapper.
NicoZelaya
approved these changes
Jul 12, 2023
mmelograno
approved these changes
Jul 12, 2023
|
Appreciate the Seems like a maintainer approval is required before I can merge 
|
|
Great suggestion @dferber90 thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edge config should be created outside of the handler. You might even want to move the whole SplitFactory client outside of the handler in case it makes sense to remove those across requests, or maybe just the PluggableStorage or the EdgeConfigWrapper.