Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kerberos support #511

Merged
merged 10 commits into from
Aug 14, 2024
Merged

Kerberos support #511

merged 10 commits into from
Aug 14, 2024

Conversation

chillaq
Copy link
Contributor

@chillaq chillaq commented Aug 13, 2024

No description provided.

@chillaq chillaq requested a review from a team as a code owner August 13, 2024 16:06
nmayorsplit
nmayorsplit reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@nmayorsplit nmayorsplit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things to update.

client/src/main/java/io/split/service/SplitHttpClientKerberosImpl.java Outdated Show resolved Hide resolved
client/src/main/java/io/split/service/SplitHttpClientKerberosImpl.java Outdated Show resolved Hide resolved
client/src/main/java/io/split/service/SplitHttpClientKerberosImpl.java Outdated Show resolved Hide resolved
client/src/main/java/io/split/service/SplitHttpClientKerberosImpl.java Outdated Show resolved Hide resolved
@chillaq chillaq requested a review from gthea August 13, 2024 20:27
sanzmauro
sanzmauro requested changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@sanzmauro sanzmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have 7 code smells. Please try to fix them before merge 🙏

Have you already reviewed them?

@chillaq
Copy link
Contributor Author

chillaq commented Aug 14, 2024

You have 7 code smells. Please try to fix them before merge 🙏

Have you already reviewed them?

I reviewed and fixed all except one, cannot use try-with-reference since the variable InputStreamReader cannot be final.

@sonarqube-pull-requests SonarQube Pull Requests
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.8% 87.8% Coverage
0.0% 0.0% Duplication

@chillaq chillaq merged commit e388362 into development Aug 14, 2024
7 checks passed
@chillaq chillaq deleted the kerberos-support branch August 14, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanzmauro sanzmauro sanzmauro approved these changes

@nmayorsplit nmayorsplit Awaiting requested review from nmayorsplit

@gthea gthea Awaiting requested review from gthea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chillaq @gthea @sanzmauro @nmayorsplit