Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clang-format #550

Open
MSallermann opened this issue Oct 31, 2019 · 2 comments · Fixed by #560 or #585
Open

Use clang-format #550

MSallermann opened this issue Oct 31, 2019 · 2 comments · Fixed by #560 or #585
Labels
idea refactoring

Comments

@MSallermann
Copy link
Member

Using clang-format seems to be a good way to enforce uniform formatting across the code.
@GPMueller GPMueller mentioned this issue Apr 2, 2020
Merged
@GPMueller GPMueller linked a pull request May 25, 2020 that will close this issue
clang-format file for homogeneous formatting #560
Merged
@GPMueller
Copy link
Member

Initial format config and formatting of ui-qt merged into develop with 4b439ce.
The remaining code should probably only slowly be updated, as it will cause pull requests to have a huge amount of conflicts.

@GPMueller GPMueller linked a pull request Jan 22, 2021 that will close this issue
More clang format #585
Merged
@GPMueller GPMueller mentioned this issue Sep 25, 2021
Open
@GPMueller
Copy link
Member

The remaining files have been formatted with commit 489df94.

@MSallermann should I add a format-check to the CI? Here is how it would look in the ci.yaml:
https://github.com/GPMueller/imgui-app/blob/8f0a1b262767887632b0c8f77b482e403d0367ad/.github/workflows/ci.yml#L125-L164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea refactoring
Projects
None yet
Milestone
No milestone
2 participants
@GPMueller @MSallermann