-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getting-started-k8s.md #283
base: master
Are you sure you want to change the base?
Conversation
New updated tutorial with latest helm chart. Need to wait for PR spiffe#119 & PR spiffe#120 to be accepeted in spiffe/spiffe-tutorials
✅ Deploy Preview for spiffe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Changed presentation of SPIRE Agent information and changed that they were created by the helm chart instead of "previous step"
This is awesome! Thank you so much for it! I think it would be nice to have Helm chart installation as a first option to use spire with k8s, but I would also leave the pure yaml files installation there as well (it probably would need some more massaging and updates. |
fixing DCO check should be fairly straight forward, though you may need to force push :) thanks for bringing this up to helm charts sync. Looking forward to your continued contributions 🥳 |
Hey @cccsss01 do you mind fixing DCO? Should be straightforward to do this. |
@cccsss01 I'm not sure that you are referencing to a correct PRs |
Correct, Looks like the PR's are referencing the wrong project I haven't been able to put time into this but it's on my list. |
PRs should be:
(Note: these are not merged, just the correct links) |
hey @cccsss01 thank you for working on this! do you still have some cycles to finish these PRs? they need the DCO to be fixed and probably a few more changes as the charts have split since this PR. I'd also support the suggestion of keeping the original k8s tutorial and manifests, and adding this as an additional preferred option. @kfox1111 and other maintainers of the hardened helm chart may also be willing to help with the tutorials and manifests |
@mchurichi Would it make sense to rename the original tutorial/manifests as something like "SPIRE from Scratch on Kubernetes"? Its still quite useful for those wanting to learn how it all works, but not as configurable / tested so "some assembly required" and not as preferred a recommendation? |
@kfox1111 yes, definitely! we should rename the old tutorial to make it clear that it's not the recommended way anymore. |
Thought - if this is removing an outdated tutorial, perhaps removing the "old way" is the way to go? To prevent confusion and help people with onboarding. |
I think this should be closed in favor of what keven fox has done. |
Seems like the consensus is to move the old getting started to a new name involving "from scratch" and then make the existing page just a small blurb helping the user choose links something like:
? Should we close this pr and start a new one for that work, or rework this one to do those things intead? |
Just my 2 cents here: |
New updated tutorial with latest helm chart. Need to wait for PR #119 & PR #120 to be accepeted in spiffe/spiffe-tutorials