Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR preview assets wrongly published to prod? #273

Closed
c4rlo opened this issue Feb 20, 2023 · 3 comments
Closed

PR preview assets wrongly published to prod? #273

c4rlo opened this issue Feb 20, 2023 · 3 comments
Assignees

Comments

@c4rlo
Copy link
Contributor

c4rlo commented Feb 20, 2023

https://spiffe.io currently has:

<link rel="stylesheet" href="https://deploy-preview-272--spiffe.netlify.app/css/style.1db1f4238dfe329e043f994d70fa2006780c816bd84f444fe31b09794695a59e.css">

(and several other references to that domain)

Note that deploy-preview-272 in there. Looks like that comes from #272, which somehow got accidentally pushed to prod?

Normally, the website still looks okay; except that on our corporate network, https://deploy-preview-272--spiffe.netlify.app/ is blocked, so there it looks completely broken because of this.

@mchurichi
Copy link
Member

Hi @c4rlo, thanks for reporting this.
Seems like some recent testing of the features implemented by #272 impacted on prod, most likely this is a messed up Netlify config. I'm taking a look and report back shortly.

@mchurichi mchurichi self-assigned this Feb 20, 2023
@mchurichi
Copy link
Member

This should be fixed now, @c4rlo could you please confirm?

@c4rlo
Copy link
Contributor Author

c4rlo commented Feb 20, 2023

Yes, this is now fixed for me. Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants