Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to exit on successful retrieval of JWT SVID #121

Closed
keeganwitt opened this issue Dec 20, 2023 · 7 comments
Closed

Add ability to exit on successful retrieval of JWT SVID #121

keeganwitt opened this issue Dec 20, 2023 · 7 comments
Milestone

Comments

@keeganwitt
Copy link
Contributor

No description provided.

@kfox1111
Copy link
Contributor

It also can not run a command on exit near as I can tell. The code should probably call the same function that does cmd execution and signaling as well as exit?

@keeganwitt
Copy link
Contributor Author

It also can not run a command on exit near as I can tell. The code should probably call the same function that does cmd execution and signaling as well as exit?

Yes, I think so. It's confusing that there's not parity here.

@keeganwitt
Copy link
Contributor Author

Actually signaling might be confusing since if there's multiple JWTs, it would signal multiple times.

keeganwitt added a commit to keeganwitt/spiffe-helper that referenced this issue Jan 18, 2024
@kfox1111
Copy link
Contributor

Actually signaling might be confusing since if there's multiple JWTs, it would signal multiple times.

The same is true on exiting? With multiple jwts I'd think the exit should happen when all have been fetched. Probably signaling, and cmd should happen the same way? But that is more tricky...

@keeganwitt
Copy link
Contributor Author

The same is true on exiting? With multiple jwts I'd think the exit should happen when all have been fetched. Probably signaling, and cmd should happen the same way? But that is more tricky...

Yea, I guess it should signal once when all the JWTs are fetched, not each time. Dunno why I didn't think of that.

@faisal-memon
Copy link
Collaborator

@keeganwitt This should be met with the daemon-mode setting released in 0.8.0. Can you confirm?

@keeganwitt
Copy link
Contributor Author

@keeganwitt This should be met with the daemon-mode setting released in 0.8.0. Can you confirm?

Yes, this is the case.

@faisal-memon faisal-memon modified the milestones: 0.9.0, 0.8.0 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants