Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening app offline causes crash #23

Open
erlend-sh opened this issue Mar 6, 2023 · 2 comments
Open

Opening app offline causes crash #23

erlend-sh opened this issue Mar 6, 2023 · 2 comments
Labels
bug Something isn't working gui GUI related

Comments

@erlend-sh
Copy link

I just tried to start up the launcher while my wifi was off. Instead of some kind of "can't connect to internet" notification, the app just crashes.

System Integrity Protection: enabled

Crashed Thread:        18  tokio-runtime-worker
Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000

Application Specific Information:
abort() called

Easiest solution here is the aforementioned no-connection notice. In the future we could consider making the app work offline, i.e. it'll still give you access to whatever you've already downloaded even if you're offline.

@zicklag
Copy link
Collaborator

zicklag commented Mar 6, 2023

In the future we could consider making the app work offline, i.e. it'll still give you access to whatever you've already downloaded even if you're offline.

Yeah, huge 👍 for that. It drives me crazy when apps don't let me get to what I have on my own omputer when I'm offline.

Maybe we could cache the release files locally whenever we download them, and then we show like an "out-of-date" or "disconnected" warning icon with a tooltip somewhere a little bit out of the way or something if we can't download new ones when we startup.

@orhun orhun added bug Something isn't working gui GUI related labels Mar 11, 2023
@orhun
Copy link
Member

orhun commented Mar 11, 2023

Agree with @zicklag here. Caching + showing a notification would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui GUI related
Projects
None yet
Development

No branches or pull requests

3 participants