Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [FR] Add a setting for custom "empty changelog" markers #36

Open
webknjaz opened this issue Sep 20, 2020 · 0 comments
Open

✨ [FR] Add a setting for custom "empty changelog" markers #36

webknjaz opened this issue Sep 20, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@webknjaz
Copy link
Member

The current implementation relies on checking whether the string "No significant changes" is present in the command output: https://github.com/sphinx-contrib/sphinxcontrib-towncrier/blob/e58f24c/src/sphinxcontrib/towncrier/__init__.py#L78.

That check is hardcoded but, in fact, this output may be different if the user decides to throw in a custom changelog template. That is why we need a setting in conf.py that would allow end-users to also override the checked phrase.

@webknjaz webknjaz added enhancement New feature or request good first issue Good for newcomers labels Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant