feat(/github/commits): support filter by path #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sidvishnoi please let me know if this looks like a reasonable direction. |
sidvishnoi
reviewed
Aug 5, 2024
sidvishnoi
reviewed
Aug 5, 2024
There was a problem hiding this comment.
This looks great to me. Just need to add some safety checks to path to avoid path traversal via the DiskCache.
Thanks @jnurthen
sidvishnoi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #434
Part of speced/respec#4754
Adds an optional path parameter to the GH commits interface.
Usage allows multiple specs hosted in a monorepo to specific either a folder or a file/folder and only return commits against that file.
Usage will require a corresponding change to gh-changelog in respec to enable this ability