Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should pom.developer.organization be a candidate fallback for sbom.organization? #129

Open
mathjeff opened this issue Aug 29, 2023 · 2 comments

Comments

@mathjeff
Copy link

mathjeff commented Aug 29, 2023

In spdx/spdx-gradle-plugin#38 we're considering whether, if pom.organization is unspecified, perhaps pom.developer.organization should be a possible fallback for sbom.organization.

I think an example pom is:

https://repo1.maven.org/maven2/org/jetbrains/annotations/13.0/annotations-13.0.pom

which contains the text:

<developers>
<developer>
<id>JetBrains</id>
<name>JetBrains Team</name>
<organization>JetBrains</organization>
<organizationUrl>http://www.jetbrains.com</organizationUrl>
</developer>
</developers>

which I think was causing this text to appear in the sbom:

“supplier" : "Person: JetBrains Team"

whereas maybe it would be better to output this text instead:

“supplier" : "Organization: JetBrains"

Perhaps it might make sense for the spdx-maven-plugin to do something similar to what's being considered for the spdx-gradle-plugin here too.

@goneall
Copy link
Member

goneall commented Aug 30, 2023

Thanks @mathjeff for pointing this out. I agree with the general direction the Gradle plugin is using.

Once there is a PR for the Gradle plugin, we can create a similar PR for the Maven plugin.

@hboutemy
Copy link
Contributor

I'm not convinced: why would the first developer data be promoted like this?
even if we code that algorithm only when there is a unique developer, but even there, the heuristics sometimes gives the result that the component provider would expect, sometimes not, then if we implement, I expect the next issue reported to "fix" the heuristics

SBOM seems to be the first time people look at the value they put (or not) for years in their pom.xml : heuristics to try to guess instead of having the owner take his decision is not something I'm really convinced about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants