Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

software/example13: Fix property name and value #82

Closed
wants to merge 5 commits into from
Closed

software/example13: Fix property name and value #82

wants to merge 5 commits into from

Conversation

bact
Copy link
Contributor

@bact bact commented May 31, 2024 •
edited
Loading

  • In JSON, fix property name and value to make it valid, based on the validation of spdx3ToGraph.
    • name:externalIdentifiers -> externalIdentifier
    • value: depends_on -> dependsOn
  • Move draw.io diagram (non-SPDX specific) to the root of the example13, also show it in the README
  • Add PlantUML diagram (SPDX 3.0 specific) to the spdx3.0/ subdirectory of the example13

bact added 5 commits June 1, 2024 00:26
@bact
software/example13: Fix property names
a9d889f 
- `externalIdentifiers` -> `externalIdentifier`
- `depends_on` -> `dependsOn`

Based on the validation of spdx3ToGraph
@bact
Remove puml files
671fb37
@bact
Use spdx-3.0 -> spdx3.0, example-13 -> example13
33b69db 
- spdx-3.0 -> spdx3.0: Make it consistent with the previous spdx2.2
- example-13 -> example13: Make it consistent with other examples naming
@bact
Add SPDX 3 diagram from spdx3ToGraph
69a1545
@bact
spdx2.2 and spdx3.0 dirs info in README
a66f759
@bact
Copy link
Contributor Author

bact commented Jun 3, 2024

Tag @rnjudge to see if you agree with the proposed changes and/or having any suggestion. Thank you.

@bact
Copy link
Contributor Author

bact commented Jun 14, 2024

The JSON is now fixed by #86

@bact bact closed this Jun 14, 2024
@bact bact mentioned this pull request Jun 14, 2024
Closed
@bact bact deleted the fix-validate-software-example13 branch June 17, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bact